Properly init in-memory usage when restoring the state #610
+13
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When restoring the state after the activity got killed, the NavController would immidiately launch the previous destination even before running the DisposableEffect. Moving the effect up fixes this timing issue.
AdamGrzybkowski
added
Bug
📲 You can test the changes from this Pull Request in Gravatar Demo by scanning the QR code below to install the corresponding build.
|
etoledom
approved these changes
Apr 18, 2025
There was a problem hiding this comment.
I was able to reproduce the issue in trunk, and these changes fixes it 🎉
I also saw another problem where the profile card wasn't showing when opening the QE with a given token, but this also seem to have been fixed with these changes.
This last issue I wasn't to reproduce it again in trunk, so I can't get a video now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #609
Description
When the "Don't keep activities" is ON, the Quick Editor state won't properly display the data inside. It's caused by a timing issue. The
QuickEditorContainer.getInstance().useInMemoryTokenStorage()that is called in theDisposableEffectis invoked after theNavControllerstarts the restored destination, so the ViewModel and its dependencies don't use the in-memory storage as they should.Moving the
DisposableEffectto a Composable higher up in the hierarchy fixes this timing issue.Testing Steps
secrets.propertiesfile with namedemo-app.bearer.token.View Profile